Skip to content

fix(foundation): collapse nested if statements in gemini sse parser#1296

Open
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Bhanudahiyaa:fix/collapsible-if-gemini-sse
Open

fix(foundation): collapse nested if statements in gemini sse parser#1296
Bhanudahiyaa wants to merge 1 commit intomofa-org:mainfrom
Bhanudahiyaa:fix/collapsible-if-gemini-sse

Conversation

@Bhanudahiyaa
Copy link
Contributor

Summary

Resolves #1295

This PR fixes 3 clippy::collapsible_if warnings inside crates/mofa-foundation/src/llm/google.rs.

Motivation

To ensure cargo clippy --workspace --all-features passes cleanly without warnings, as per the CONTRIBUTING.md guidelines.

Changes

  • mofa-foundation: Collapsed the nested if and if let blocks at lines 448-463 of google.rs into a single compound condition using &&. The underlying logic is completely unchanged.

Related Issues

Resolves #

Testing

  • Verified cargo clippy --workspace --all-features -- -D errors passes.
  • Verified cargo fmt --check passes.
  • Verified cargo test --workspace --all-features passes.

Checklist

  • cargo fmt --check passes
  • cargo clippy --workspace --all-features -- -D errors passes
  • cargo test --workspace --all-features passes
  • cargo build --examples succeeds
  • cargo doc --workspace --no-deps --all-features succeeds
  • Architecture layer rules respected (see CONTRIBUTING.md)
  • Relevant documentation updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: Fix clippy::collapsible_if warnings in Gemini SSE parser

1 participant