validation added #150
Merged
validation added #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thehighestmath
requested changes
Sep 21, 2025
src/git_logger.py
Outdated
| for repo in list_repos: | ||
| pattern = r'[0-9A-Za-z-_\.]+/[0-9A-Za-z-_\.]+' | ||
| if not re.fullmatch(pattern, repo): | ||
| print('Names must be in the format <organization or owner>/<name>') |
There was a problem hiding this comment.
- Names must be in the format / поменять на Repository name must be in the format /
- Использовать logging.error вместо принта. Пример тут Так код выглядит более профессионально, плюс там добавляется время ошибки, что иногда может быть полезно
src/git_logger.py
Outdated
Comment on lines
39
to
41
| for repo in list_repos: | ||
| pattern = r'[0-9A-Za-z-_\.]+/[0-9A-Za-z-_\.]+' | ||
| if not re.fullmatch(pattern, repo): |
There was a problem hiding this comment.
Тут каждый раз в цикле собирается дерево регулярно по новой
Лучше собрать (скомпилировать) регулярное выражение 1 раз и переиспользовать
pattern = re.compile(r'[0-9A-Za-z-_\.]+/[0-9A-Za-z-_\.]+')
for repo in list_repos:
if not pattern.fullmatch(repo):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.