433 aspect ratio check #756
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
requested changes
Dec 7, 2025
Collaborator
HadronCollider
left a comment
HadronCollider
left a comment
There was a problem hiding this comment.
- Подтяните изменения из ветки dev
- Новые критерии импортируются в модуле https://github.com/moevm/document_insight_system/blob/master/app/main/checks/presentation_checks/__init__.py (для презентаций в своём), чтобы они могли быть использованы в системе - сейчас в запущенной системе к ним нет доступа и они не используются (= не могут быть запущены для документов)
- При нестандартных значениях возможен забавный результат (но проверка работает верно)
-
| description = "" | ||
| id = 'pres_aspect_ratio_check' | ||
|
|
||
| def __init__(self, file_info, correct_ratios=["4:3", "16:9"]): |
Collaborator
There was a problem hiding this comment.
Вспомните про неизменяемость объектов и работу значений по умолчанию - к счастью, в коде значение correct_ratios никак не меняется, т.е. непредвиденных результатов не будет, но лучше изменить на кортеж или None (при этом подавать в конструктор могут и список)
Comment on lines
+35
to
+38
| self.correct_ratios = [Ratio(*map(int, x.split(':'))) for x in correct_ratios] | ||
|
|
||
| def __is_correct_ratio(self, aspect_ratio: Ratio): | ||
| return any(aspect_ratio == ratio for ratio in self.correct_ratios) |
Collaborator
There was a problem hiding this comment.
- Для проверки вхождения aspect_ratio в self.correct_ratios достаточно конструкции
in - При использовании множества (set) проверка вхождения будет быстрее (
O(1)), чем линейный поиск в списке (O(n))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача #433