feat: add manifest process state grammar - #195
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 603253dc9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| case "created": | ||
| case "removing": | ||
| return "starting"; |
There was a problem hiding this comment.
Treat created containers as off
When Docker Compose reports a service as created (and this adapter also assigns created to configured services with no ps entry in src/docker.ts), the container is not running rather than actively starting; Docker's ps docs list created separately from running, where running is the state after docker start/docker run (https://docs.docker.com/reference/cli/docker/container/ls/). Mapping it to starting makes never-started Compose services show Str indefinitely and skews panel summaries/colors until the user starts them.
Useful? React with 👍 / 👎.
|
Addressed Codex feedback: Docker/Compose now maps to , with regression coverage in . CI is green. |
|
Addressed Codex feedback: Docker Compose created state now maps to off, with regression coverage in runtime-status.test.ts. CI is green. |
Closes #181
Closes #182
Closes #183
Closes #184
Summary
Tests
Notes
Self-reviewed diff for scope, secrets, debug logs, and acceptance criteria.