FIX-#4354: Fix df.loc with tuple argument on multiindex dataframe #4421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naren-ponder
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4421 +/- ##
===========================================
- Coverage 86.39% 57.87% -28.52%
===========================================
Files 228 228
Lines 18367 18371 +4
===========================================
- Hits 15868 10633 -5235
- Misses 2499 7738 +5239
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Doesn't this solution only work if we have 2 levels? Multiindexes can have more than 2 levels, so the solution might need a for loop to iterate over elements of the tuple. |
|
|
This also fails the case where we try and import modin.pandas as pd
import numpy as np
arrays = [
np.array(["bar", "bar", "baz", "baz", "foo", "foo", "qux", "qux"]),
np.array(["one", "two", "one", "two", "one", "two", "one", "two"]),
]
df = pd.DataFrame(np.random.randn(8, 4), index=arrays)
df.loc['bar', 0]gives us an error that it can't find key one -0.681044
two 1.607220
Name: 0, dtype: float64 |
|
|
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Signed-off-by: Naren Krishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Naren Krishna [email protected]
What do these changes do?
Fix df.loc with tuple argument on multi-index dataframe.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.pyblack --check modin/ asv_bench/benchmarks scripts/doc_checker.pygit commit -sdocs/development/architecture.rstis up-to-date