Skip to content

refactor fetch_ready_timers to be able to use it in tests #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesnik512 merged 1 commit into from
Dec 22, 2025
Merged

refactor fetch_ready_timers to be able to use it in tests #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions redis_timers/timers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,8 @@ def include_routers(self, *routers: Router) -> None:
def _convert_datetime_to_redis_format(datetime_point: datetime.datetime) -> str:
return str(int(datetime_point.timestamp()))

async def _fetch_ready_timers(self) -> list[str]:
current_timestamp: typing.Final = self._convert_datetime_to_redis_format(
datetime.datetime.now(tz=TIMEZONE),
)
async def fetch_ready_timers(self, timestamp: datetime.datetime) -> list[str]:
current_timestamp: typing.Final = self._convert_datetime_to_redis_format(timestamp)
return await self.redis_client.zrangebyscore(
settings.TIMERS_TIMELINE_KEY,
"-inf",
Expand Down Expand Up @@ -85,7 +83,7 @@ async def _handle_one_timer(self, timer_key: str) -> None:
await handler.handler(payload, self.context)

async def handle_ready_timers(self) -> None:
ready_timers = await self._fetch_ready_timers()
ready_timers = await self.fetch_ready_timers(datetime.datetime.now(tz=TIMEZONE))
for timer_key in ready_timers:
lock = consume_lock(
redis_client=self.redis_client,
Expand Down
Loading