Fixing segmentation error on test_flatten_layer #230
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milancurcic
requested changes
Sep 5, 2025
There was a problem hiding this comment.
Sorry, I can't approve this because there is no explanation of what was wrong and what was fixed. A lot of code that works was also re-written in different style, which is not welcome. I think a good use would be for the AI to identify the cause of the segfault, and for only that part of the code to be changed.
|
I think that the issue is deeper than that, because I get a Segfault with my own application too. I'll to get a closer look later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made AI rewrite the code asking it to avoid possible segerrors and apparently it worked. Have a look .