feat(review): add go-to-line prompt - #808
Draft
IAMLEIzZ wants to merge 1 commit into
Draft
Conversation
Add a go-to-line flow: `:` opens a line-number prompt in the status bar, and Enter jumps the current-line cursor to that line in the selected file so `c` can annotate it directly. Bare numbers use the current file's numbering (the note labels' `R` side); an `l` prefix targets the source file's numbering (the `L` side). The jump resolves through the shared revealLine path, and line-level navigation no longer depends on the cursor_line display option: with the marker off, the target cursor is synthesized on demand instead of falling back to the hunk. The command closes an open menu when triggered, reports failures as transient notices (which now outrank the filter summary), and the bundled vim-navigation example's command line moves from `:` to `;` since built-ins shadow extension chords by design.
|
@IAMLEIzZ is attempting to deploy a commit to the Modem Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #805
Summary
Adds a go-to-line flow to the review UI:
:opens a small line-number prompt in the status bar (the same inline-input pattern as the/file filter), and Enter jumps the current-line cursor to that line in the selected file soccan annotate it directly. A bare number uses the current file's numbering (theRside the note labels use); anlprefix such as:l42targets the source file's numbering (theLside). Escape cancels, and a line that is not part of the diff reports a transient notice naming the side instead of jumping silently.The jump resolves through the existing shared
revealLinepath that the sessionnavigatecommand uses, so scrolling, selection, and note targeting all land consistently. Line-level navigation is also decoupled from thecursor_linedisplay option: when the marker is off, the target cursor is synthesized on demand from the render plan (no full stop-list rebuild), so jumping and annotating stay precise instead of degrading to the hunk.Notes
hunk.review.gotoLineis registered in the shared command catalog with:as the default chord, is remappable via[keybindings], and closes an open menu when triggered.:to;, since built-in chords shadow extension chords by design.filter=…summary so they stay visible while a file filter is active.Testing
:2delivery, non-digit stripping, Escape cancel, new/old side targeting, closing an open menu,cursor_line = "off"jump and annotate precision, selected-file targeting, and the two-stage filter Escape.useTerminalReviewcontract tests updated for the synthesized-cursor reveal; vim example unit tests and PTY updated for the move to;.