Skip to content

Tighten the review render-plan contract#65

Merged
benvinegar merged 1 commit into
mainfrom
feat/review-render-plan-contract
Mar 23, 2026
Merged

Tighten the review render-plan contract#65
benvinegar merged 1 commit into
mainfrom
feat/review-render-plan-contract

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • make the single visible inline-note policy explicit in buildReviewRenderPlan()
  • clarify anchor and guide selection for range-backed vs range-less notes
  • expand render-plan contract coverage for deletion-only notes, multi-hunk diffs, hidden-header anchors, and multi-note metadata

Why

The render-plan refactor introduced a good abstraction, but some key behaviors were still implicit:

  • only the first visible note rendered inline, but that policy lived in a bare visibleAgentNotes[0]
  • range-less notes anchored correctly in practice, but the guide behavior was not clearly expressed
  • tests covered the happy path more than the boundary conditions this abstraction is supposed to own

This follow-up turns those behaviors into an explicit contract so future note UX and windowing work can build on a clearer foundation.

Testing

  • bun run typecheck
  • bun test
  • pseudo-TTY smoke run of bun run src/main.tsx diff ...

@benvinegar benvinegar merged commit eb49912 into main Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant