Skip to content

Refactor split diff rendering around an explicit review row plan#64

Merged
benvinegar merged 1 commit into
mainfrom
feat/review-render-plan
Mar 23, 2026
Merged

Refactor split diff rendering around an explicit review row plan#64
benvinegar merged 1 commit into
mainfrom
feat/review-render-plan

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • add buildReviewRenderPlan(...) as an explicit presentational planning layer on top of semantic Pierre diff rows
  • move inline-note anchoring, guide-range membership, guide-cap placement, and hunk anchor assignment out of PierreDiffView's ad hoc render loop
  • add planner-focused coverage for split note ranges, hidden hunk headers, and range-less note fallback behavior

Testing

  • bun test
  • bun run typecheck
  • bunx oxlint . --deny-warnings
  • bunx oxfmt --check .
  • bun run test:tty-smoke

@benvinegar benvinegar merged commit 67b86f5 into main Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant