feat(extensions): prototype constrained JSX file views - #637
Merged
benvinegar merged 6 commits intoJul 29, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
benvinegar
marked this pull request as ready for review
July 29, 2026 15:41
Contributor
|
Too many files changed for review. ( Bypass the limit by tagging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hunk.apiVersionto 3Context
This is a stacked draft on top of #632. It preserves and evaluates the JSX/OpenTUI direction without rewriting that PR.
The contract mounts components per validated row rather than handing an extension an entire file section. Each component declares a fixed terminal height and retains symbolic spans as fallback. Hunk snapshots accepted layouts, clips ordinary descendants to the declared rectangle, mounts only visible rows, and continues to own the surrounding multi-file review stream.
Release ordering
The streamlined file-view shape differs from the earlier API-v2 shape on the stacked base. This PR advances the extension API to version 3 so the contracts remain distinguishable if #632 ships separately. Prefer landing the stack in one release; do not publish the API-v2 file-view contract as final documentation for the version-3 shape.
Interaction and state policy
Demo gallery
examples/extensions/jsx-file-view-gallery/contains three conservative public-API-only previews with checked-in before/after fixtures. Its mixed-review launcher creates a temporary five-file Git working tree where all three previews remain active between raw Markdown and Python diffs in one scrollable review stream.Known limitations
Validation
bun run typecheckbun run lintbun run check:packThis PR description was generated by Pi using OpenAI GPT-5