Skip to content

ci: download only platform artifacts for releases#433

Merged
benvinegar merged 1 commit into
mainfrom
fix/release-artifact-download
Jun 13, 2026
Merged

ci: download only platform artifacts for releases#433
benvinegar merged 1 commit into
mainfrom
fix/release-artifact-download

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • Restrict the release staging artifact download to hunkdiff-* platform artifacts.
  • Keep the uploaded benchmark comparison artifact from being interpreted as a prebuilt platform package.
  • Note the release-staging fix in the 0.15.3 changelog section.

Tests

  • bun run format:check
  • bun run typecheck

This PR description was generated by Pi using OpenAI GPT-5

@benvinegar benvinegar enabled auto-merge (squash) June 13, 2026 18:18
@greptile-apps

greptile-apps Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes the stage-release job by adding pattern: hunkdiff-* to its artifact download step, preventing the release-benchmark-comparison artifact from being pulled into dist/release/artifacts and misinterpreted as a platform binary package during staging.

  • Workflow fix: The stage-release download now mirrors the filter already used by create-github-release, making the two jobs consistent.
  • Changelog: A single bullet is added to the 0.15.3 Fixed section describing the fix.

Confidence Score: 5/5

Safe to merge — the change is a one-line targeted fix that aligns the stage-release artifact download with the already-correct create-github-release job.

The single added line (pattern: hunkdiff-*) is a minimal, low-risk correction. The identical filter was already present in the create-github-release job, confirming the pattern is well-understood and correct. The changelog entry is accurate and placed in the right version section.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/release-prebuilt-npm.yml Adds pattern: hunkdiff-* to the artifact download step in stage-release, matching the filter already present in create-github-release; prevents the release-benchmark-comparison artifact from polluting the staging directory.
CHANGELOG.md Adds one bullet to the 0.15.3 Fixed section documenting the release-staging artifact fix.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[release-benchmark-gate] -->|uploads: release-benchmark-comparison| STORE[(Artifact Store)]
    A --> B[build-binaries matrix]
    B -->|uploads: hunkdiff-linux-arm64\nhunkdiff-linux-x64\nhunkdiff-windows-x64\nhunkdiff-darwin-x64\nhunkdiff-darwin-arm64| STORE

    STORE -->|pattern: hunkdiff-* BEFORE FIX: ALL artifacts| C[stage-release]
    STORE -->|pattern: hunkdiff-* already correct| D[create-github-release]

    C -->|stage:prebuilt:release| E[Staged npm packages]
    C -->|uploads: staged-prebuilt-npm-release| F[publish]

    style A fill:#f9f,stroke:#333
    style C fill:#bbf,stroke:#333
    style D fill:#bfb,stroke:#333
Loading

Reviews (1): Last reviewed commit: "ci: download only platform artifacts for..." | Re-trigger Greptile

@benvinegar benvinegar merged commit 3a2ba1c into main Jun 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant