Skip to content

Clarify AppHost/App naming#138

Merged
benvinegar merged 1 commit into
mainfrom
clarify-app-host-naming
Mar 30, 2026
Merged

Clarify AppHost/App naming#138
benvinegar merged 1 commit into
mainfrom
clarify-app-host-naming

Conversation

@benvinegar

Copy link
Copy Markdown
Member

Summary

  • rename the inner UI component from AppShell to App
  • rename the outer lifecycle wrapper from App to AppHost
  • rename resetShell to resetApp and update related comments/tests for terminology consistency
  • update main entrypoint, tests, and benchmarks to use the new naming

Testing

  • bun run typecheck
  • bun test test/ui-lib.test.ts test/app-responsive.test.tsx

@greptile-apps

greptile-apps Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR is a pure naming refactor across 16 files, clarifying the roles of two components in src/ui/App.tsx: the inner UI component is renamed from AppShellApp, and the exported lifecycle/session-management wrapper is renamed from AppAppHost. The accompanying option resetShellresetApp and state variable shellVersionappVersion are updated consistently, along with JSDoc comments throughout the library files and all test/benchmark usages.

Key changes:

  • AppShell (internal layout component) → App
  • App (exported session lifecycle wrapper) → AppHost
  • resetShell option and shellVersion state → resetApp / appVersion
  • All imports in src/main.tsx, benchmarks, and 6 test files updated to AppHost
  • JSDocs in appMenus.ts, files.ts, responsive.ts, sidebar.ts, and ModalFrame.tsx updated to remove "shell" terminology

The rename is exhaustive — a search for any remaining AppShell, resetShell, or shellVersion symbols returns no matches. No functional logic was changed.

Confidence Score: 5/5

Safe to merge — this is a pure rename with no functional changes and all references are consistently updated.

Every usage of the old names (App, AppShell, resetShell, shellVersion) has been updated across all 16 affected files, including source, tests, and benchmarks. No old symbols remain in the codebase, and no logic was altered.

No files require special attention.

Important Files Changed

Filename Overview
src/ui/App.tsx Core rename: AppShell → App (internal component), App → AppHost (exported wrapper), resetShell → resetApp, shellVersion → appVersion; all changes are consistent and no old symbols remain.
src/main.tsx Import and JSX usage updated from App to AppHost; entrypoint correctly reflects the new exported name.
src/ui/hooks/useHunkSessionBridge.ts Callback option type updated from resetShell to resetApp to match the renamed option in AppHost.reloadSession.
test/app-interactions.test.tsx All imports and JSX usages of App updated to AppHost; test descriptions updated; no functional test logic changed.
test/app-responsive.test.tsx App → AppHost import and usage; describe('responsive shell', ...) renamed to describe('responsive app', ...).
benchmarks/large-stream.ts Import and three React.createElement calls updated from App to AppHost; no functional changes.

Reviews (1): Last reviewed commit: "Clarify AppHost/App naming" | Re-trigger Greptile

@benvinegar benvinegar merged commit 7f03385 into main Mar 30, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant