fix(stdio): preserve multi-byte UTF-8 across chunk boundaries - #2041
Closed
fmunteanu wants to merge 3 commits into
Closed
fix(stdio): preserve multi-byte UTF-8 across chunk boundaries#2041fmunteanu wants to merge 3 commits into
fmunteanu wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: 503444a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes UTF-8 corruption in stdio when multi-byte sequences split across chunk boundaries.
Motivation and Context
ReadBufferdecodes withBuffer.toString('utf8', ...), which produces replacement characters when a multi-byte sequence (em-dash, emoji) splits across chunks. The corrupted bytes breakJSON.parseand clients see misleading "expected object, received undefined" Zod errors pointing at the wrong field.How Has This Been Tested?
Swapped
Buffer.toStringforTextDecoderin streaming mode, which holds incomplete multi-byte sequences across chunks. Added tests for em-dash, 3-byte emoji, 4-byte emoji, and byte-by-byte delivery. All stdio tests pass locally.Breaking Changes
None. Public API unchanged.
Types of changes
Checklist
Additional context
TextDecoderis a Web Standards API (no new dependency) used bynode:readlinefor the same reason.