Skip to content

Enable building with the Swift Linux SDK #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 14, 2025
Merged

Conversation

t089
Copy link
Contributor

@t089 t089 commented Aug 6, 2025

This adds support for compiling against the Swift Linux SDK.

Motivation and Context

Building portable mcp servers for linux is great.

How Has This Been Tested?

Used this patch to build, compile and deploy a stdio mcp server on linux.

Breaking Changes

No.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

I think with this change we could remove the !os(Linux) in Package.swift which anyhow does make much sense in the scope of cross-compilation.

@mattt
Copy link
Contributor

mattt commented Aug 10, 2025

Hi @t089. Thanks for opening this PR! Sorry for not responding sooner.

I previously opened #63, which I believe makes equivalent changes. My blocker there was not having a way to provide test coverage. Can you think of a way to make that work?

@t089
Copy link
Contributor Author

t089 commented Aug 14, 2025

@mattt Ah, yes, sorry didn't see this before. I've added a CI step that builds the project using the Static Linux SDK. It is reusing work from this PR: swiftlang/github-workflows#142

@t089
Copy link
Contributor Author

t089 commented Aug 14, 2025

I See that you tried to run tests with the musl SDK. Yes, that is not supported. I think we can for now only enable the "building" part. I would say this is fine, as we are testing on linux in the other CI job.

@mattt
Copy link
Contributor

mattt commented Aug 14, 2025

Oh hey, CI is passing. Nice work, @t089!

Anything else to do here? Or is this ready to merge?

Edit for simultaneous response 😂

I See that you tried to run tests with the musl SDK. Yes, that is not supported. I think we can for now only enable the "building" part. I would say this is fine, as we are testing on linux in the other CI job.

I agree. More important to get this into the hands of folks with assurance that things at least build, than to get full test coverage from the jump.

@t089
Copy link
Contributor Author

t089 commented Aug 14, 2025

fine with me!

@mattt mattt merged commit e019cb6 into modelcontextprotocol:main Aug 14, 2025
5 checks passed
@mattt
Copy link
Contributor

mattt commented Aug 14, 2025

Awesome. Thanks again for your help with this, @t089! I'll cut a new patch release now.

@mattt
Copy link
Contributor

mattt commented Aug 14, 2025

This is now live in 0.10.1 🎉

@t089 t089 deleted the musl branch August 14, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants