Skip to content

Add support for Google Artifact Registry (GAR) #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add support for Google Artifact Registry (GAR) #692

wants to merge 5 commits into from
+257 −802

Conversation

@rdimitrov
Copy link
Member

@rdimitrov rdimitrov commented Oct 21, 2025 •
edited
Loading

Motivation and Context

The following PR:

  • Deprecates the existing OCI reference parser
  • Deprecates the existing OCI way of authenticating and accessing the image manifest
  • Replaces the above by leveraging go-containerregistry
  • Introduces support for Google Artifact Registry
  • Enables us to easily add support for other OCI-compliant registries in the future
  • Introduces better error handling
  • Introduces custom context timeouts for validation

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

Related to #427

@rdimitrov rdimitrov requested a review from domdomegg October 22, 2025 09:34
domdomegg
domdomegg reviewed Oct 23, 2025
View reviewed changes
internal/validators/registries/oci_test.go
name: "Docker Hub should be allowed",
identifier: "docker.io/test/image:latest",
// Will fail on image not found, but registry should be accepted
expectError: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find images that do work? So we can be more certain the tests are working properly.

domdomegg
domdomegg requested changes Oct 23, 2025
View reviewed changes
Copy link
Member

@domdomegg domdomegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, could we fix the tests to use working images first though? (or at least validate that it's a 404 error rather than any error)

@rdimitrov rdimitrov force-pushed the allow-google-artifact-registry branch 2 times, most recently from ca1683b to 5458edf Compare October 24, 2025 09:58
@rdimitrov rdimitrov force-pushed the allow-google-artifact-registry branch from 5458edf to 0c5d736 Compare October 24, 2025 09:59
@rdimitrov rdimitrov force-pushed the allow-google-artifact-registry branch from 0c5d736 to ae78b7b Compare October 24, 2025 10:11
@rdimitrov rdimitrov requested a review from domdomegg October 24, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@domdomegg domdomegg Awaiting requested review from domdomegg

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdimitrov @domdomegg