Add support for ECDSA P-384 #685
Merged
+1,389
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelverhagen
force-pushed
the
joelverhagen/ecdsa
branch
from
ac29832 to
1b45a39
Compare
joelverhagen
changed the title
toby
previously approved these changes
Oct 22, 2025
joelverhagen
force-pushed
the
joelverhagen/ecdsa
branch
from
1b45a39 to
2ccf2d0
Compare
domdomegg
reviewed
Oct 22, 2025
domdomegg
reviewed
Oct 22, 2025
domdomegg
reviewed
Oct 22, 2025
Co-authored-by: adam jones <[email protected]>
Co-authored-by: adam jones <[email protected]>
9 tasks
toby
approved these changes
Oct 23, 2025
domdomegg
approved these changes
Oct 23, 2025
Contributor
Author
|
@rdimitrov would you like to review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See #482 (comment) for full details.
This adds ECDSA P-384 (a popular NIST approved curve) in addition to Ed25519.
How Has This Been Tested?
I have tested with a local deployment against
mcp.joelverhagen.com. Also, I have added significant tests.Breaking Changes
None. (hopefully)
Types of changes
Checklist
Additional context
@domdomegg and I spoke a bit about this on Discord: https://discord.com/channels/1358869848138059966/1369487942862504016/1423710918180606052