-
Couldn't load subscription status.
- Fork 447
Add support for on-device packages in MCP Registry #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Introduced `on_device` registry type for pre-installed servers. - Added optional `manifest` and `__dirname` fields in package objects. - Updated validation logic to accept on-device packages without remote checks. - Enhanced documentation and examples for on-device server usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm supportive of adding an on_device type. Very excited to see this working.
Regarding including the MCPB manifest, I'm a little less convinced. I worry this will lead to more duplication, which then raises the possibility for things to be out of sync between the manifest in the server.json and the manifest in the package itself. This usually opens up cans of worms around security etc. I also am just generally not sure if we want to be adding more things
I think if you want a manifest, it might be best to either:
- link to it as the identifier or similar for on_device type?
- add it in publisher provided or some other _meta for now, and if it gains wide adoption we promote it into the main package schema?
|
thanks @domdomegg! Starting with the manifest (+ __dirname) in the server's Ideally, I'll update the PR to put it in |
…specific fields and update changelog; those fields now go into _meta under com.microsoft.windows (or other vendor-specific namespace)
I think for now we wanted to keep it on the higher level so we don't bloat the format. For example on our side, we handle package specific meta by having a map of extensions under the _meta vendor which we map like - map[package]:{} |
|
Hmm some of the MCPB tests are failing in CI - are you able to look into these and fix them? |
on_deviceregistry type for pre-installed servers.manifestand__dirnamefields in package objects.Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context