Isolate the stdio server's stdin and stdout from handler subprocesses - #3117
Merged
Claude / Claude Code Review
completed
Jul 24, 2026 in 21m 9s
Code review found 1 potential issue
Found 1 candidates, confirmed 1. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | tests/interaction/_requirements.py:3920-3928 |
stream-purity divergence note omits the buffered exit-drain gap |
Annotations
Check warning on line 3928 in tests/interaction/_requirements.py
claude / Claude Code Review
stream-purity divergence note omits the buffered exit-drain gap
The stream-purity divergence note here is the fifth statement of the diversion claim that the flushed-output doc sweep (885c6aa/cc9016c7) missed: its "Remaining gaps" enumeration omits the author-confirmed residue that a block-buffered handler print() staying unflushed during the session drains onto the restored fd 1 (the protocol stream) at interpreter exit. One sentence added to the gap list, matching the wording already applied to the four docs pages, keeps this machine-tracked conformance re
Loading