fix: Raise exceptions in default ClientSession message handler (#1401) #1595
+56
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1401.
test_notification_validation_error()). Previously, a RuntimeError was raised for unknown IDs, but it was swallowed by the old default message handler. With the new exception-raising behavior, keeping the RuntimeError would crash the session on benign timeout scenarios.Motivation and Context
It solves the issue described in #1401 where exceptions in the default message handler for the ClientSession were being swallowed, which leads to silent failures that are difficult to debug.
How Has This Been Tested?
Added unit test for this, also
test_notification_validation_error()intest_88_random_error.pyBreaking Changes
Technically yes because those who use the default message handler and were not receiving silent errors will now start seeing them. Those who override the message handler are not affected.
Types of changes
Checklist
Additional context