Fix: Handle logging/setLevel request for server #358
Merged
+146
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements logging level filtering for the Model Context Protocol Kotlin SDK. When a client sets a logging level, the server now filters outgoing log messages based on severity, sending only messages at or above the configured level.
- Added server-side logging level filtering based on client-set level
- Added test coverage for logging level request handling and filtering behavior
- Minor refactoring to remove redundant type parameter in client request
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| kotlin-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt | Implements logging level filtering logic with severity-based comparison and request handler registration |
| kotlin-sdk-test/src/commonTest/kotlin/io/modelcontextprotocol/kotlin/sdk/client/ClientTest.kt | Adds test validating that server filters messages based on client-set logging level |
| kotlin-sdk-client/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/client/Client.kt | Removes redundant type parameter from request call |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kotlin-sdk-test/src/commonTest/kotlin/io/modelcontextprotocol/kotlin/sdk/client/ClientTest.kt
Outdated
Show resolved
Hide resolved
...-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
Outdated
Show resolved
Hide resolved
9 tasks
kpavlov
requested changes
Nov 3, 2025
...-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
Outdated
Show resolved
Hide resolved
...-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
Outdated
Show resolved
Hide resolved
...-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
Outdated
Show resolved
Hide resolved
...-sdk-server/src/commonMain/kotlin/io/modelcontextprotocol/kotlin/sdk/server/ServerSession.kt
Show resolved
Hide resolved
kotlin-sdk-test/src/commonTest/kotlin/io/modelcontextprotocol/kotlin/sdk/client/ClientTest.kt
Outdated
Show resolved
Hide resolved
| ) | ||
|
|
||
| // Only warning and error should be received | ||
| assertEquals(2, receivedMessages.size, "Should receive only 2 messages (warning and error)") |
There was a problem hiding this comment.
Shouldn't awaitility be used here?
It will be needed for sure to verify rate-limiting
There was a problem hiding this comment.
it's common code, I used delay
kotlin-sdk-test/src/commonTest/kotlin/io/modelcontextprotocol/kotlin/sdk/client/ClientTest.kt
Outdated
Show resolved
Hide resolved
| val serverSession = serverSessionResult.await() | ||
|
|
||
| // Set logging level to warning | ||
| val result = client.setLoggingLevel(LoggingLevel.warning) |
There was a problem hiding this comment.
It's easy to write a parametrized test verifying all logging levels
kotlin-sdk-test/src/commonTest/kotlin/io/modelcontextprotocol/kotlin/sdk/client/ClientTest.kt
Outdated
Show resolved
Hide resolved
devcrocod
force-pushed
the
devcrocod/logging-levels
branch
from
a5dd29e to
f6b6ce4
Compare
devcrocod
force-pushed
the
devcrocod/logging-levels
branch
from
f6b6ce4 to
d8f972c
Compare
kpavlov
approved these changes
Nov 3, 2025
| ) | ||
| } | ||
|
|
||
| delay(100) |
There was a problem hiding this comment.
awaitility is more correct than delay
There was a problem hiding this comment.
it's common code, I used delay
kpavlov
force-pushed
the
devcrocod/logging-levels
branch
from
d8f972c to
1162179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #293
Also fixed a bug with initialization: properties must be declared before the init block; otherwise, the initialization order is violated and an NPE will occur in the init block.
Motivation and Context
After initialization, MCP clients send a
logging/setLevelrequest if the logging capability is enabled. This request was previously not handled, leading to an error that blocked the use of the MCP server in the inspector and other clients.How Has This Been Tested?
Added integration test
Breaking Changes
None
Types of changes
Checklist