Follow-up improvements for #289 and #333 #335
Open
+157
−76
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
To address feedback from #289 and improve areas that needed enhancement.
How Has This Been Tested?
[x] Unit tests
Breaking Changes
No
Types of changes
Checklist
Additional context
This is a follow-up PR to #289 and #333.
Changes made:
labelPatternandnamePatternare now defined in theClientcompanion object to prevent repeated regex compilationJsonConverterutility object to improve code organization and reusabilityClientMetaParameterTestto verify actual values rather than just absence of exceptionsNote
Once #333 is merged, I will apply the new MockTransport to this PR. Until then, some test failures are expected.
Happy to discuss any suggestions for improvement.