fix: Remove @SerialName annotation for inputSchema #105
+1
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
May 26, 2025
|
@e5l Thanks for the review, I think that the tests on the main branch are not passing either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed incorrect @SerialName on inputSchema
Motivation and Context
Incorrect deserialization caused all tools to fail to invoke.
How Has This Been Tested?
Yes
Breaking Changes
No version has used it yet.
Types of changes
Checklist
Additional context
https://modelcontextprotocol.io/docs/concepts/tools
Both the server code and the MCP specifications use camelCase format.
https://github.com/modelcontextprotocol/java-sdk/blob/07e7b8fd6bac47be4527f97451f8cdd95ed31a38/mcp/src/main/java/io/modelcontextprotocol/spec/McpSchema.java#L720
Other sdk also use input_schema
https://github.com/anthropics/anthropic-sdk-java
#97 should refer to the content of this repository, not mcp.