Standard header name used in mcp #320
Open
+31
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JermaineHua <[email protected]>
# Conflicts: # mcp-spring/mcp-spring-webflux/src/main/java/io/modelcontextprotocol/client/transport/WebClientStreamableHttpTransport.java
chemicL
reviewed
Jun 17, 2025
chemicL
reviewed
Jun 17, 2025
| /** | ||
| * Standard header name used in MCP JSON-RPC request and responses. | ||
| */ | ||
| public static final class Headers { |
There was a problem hiding this comment.
I feel that this belongs around something like McpHttpTransport interface rather than in the McpSpec, which is more about the JSON-RPC layer.
There was a problem hiding this comment.
The primary purpose here is to provide users with the MCP standard header name information. The MCP-Session-Id does belong to the transport category. Of course, I have omitted the last-event-id here. At present, I think defining these header names as part of the MCPSchema is the most reasonable approach because I haven't thought of any other more reasonable alternatives. These header names are indeed mentioned in the Specification. Do you have any better suggestions? @chemicL
chemicL
requested changes
Jun 17, 2025
# Conflicts: # mcp-spring/mcp-spring-webflux/src/main/java/io/modelcontextprotocol/client/transport/WebClientStreamableHttpTransport.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context