Skip to content

Testing CI with an empty commit - #31

Closed
jonathanhefner wants to merge 1 commit into
modelcontextprotocol:mainfrom
jonathanhefner:empty-commit
Closed

Testing CI with an empty commit#31
jonathanhefner wants to merge 1 commit into
modelcontextprotocol:mainfrom
jonathanhefner:empty-commit

Conversation

@jonathanhefner

Copy link
Copy Markdown
Member

Testing CI with an empty commit

@jonathanhefner

Copy link
Copy Markdown
Member Author

Notice that CI has failed for an empty commit even though the commit on which it is based (8ac79a9) passed.

I'm not sure why package-lock.json was added to .gitignore, but I think we should track it in git to enable deterministic builds and prevent these kind of surprise failures.

(For #29, I ended up bumping a dependency version in package.json to make everything work, but that doesn't seem like a good long-term solution. ...It would be nice to merge #29 before addressing this though! 😄)

@ochafik

ochafik commented Nov 27, 2025

Copy link
Copy Markdown
Contributor

I'm not sure why package-lock.json was added to .gitignore, but I think we should track it in git to enable deterministic builds and prevent these kind of surprise failures.

@jonathanhefner I panicked after accidentally pushing a package-lock.json w/ packages resolved from an internal corporate npm mirror. Happy to reinstate them, esp. if we can throw in a lil automated test that checks it only contains urls on npmjs.org or whatever it is.

@jonathanhefner

Copy link
Copy Markdown
Member Author

@ochafik Added with a CI check in #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants