You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Notice that CI has failed for an empty commit even though the commit on which it is based (8ac79a9) passed.
I'm not sure why package-lock.json was added to .gitignore, but I think we should track it in git to enable deterministic builds and prevent these kind of surprise failures.
(For #29, I ended up bumping a dependency version in package.json to make everything work, but that doesn't seem like a good long-term solution. ...It would be nice to merge #29 before addressing this though! 😄)
I'm not sure why package-lock.json was added to .gitignore, but I think we should track it in git to enable deterministic builds and prevent these kind of surprise failures.
@jonathanhefner I panicked after accidentally pushing a package-lock.json w/ packages resolved from an internal corporate npm mirror. Happy to reinstate them, esp. if we can throw in a lil automated test that checks it only contains urls on npmjs.org or whatever it is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing CI with an empty commit