-
Notifications
You must be signed in to change notification settings - Fork 532
Add fields missing in the specification #837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fields missing in the specification #837
Conversation
Maybe I'm miss something, but I do not find a way how I can return resource with name. it got missing somewhere. And plain Resource according to documentation is not part of |
Name and Title are on McpServerResourceAttribute: csharp-sdk/src/ModelContextProtocol.Core/Server/McpServerResourceAttribute.cs Lines 131 to 134 in 445ea42
|
Honestly I don't get it. It seems from spec that Name in case of files, is name of the file, and Title is human readable file description of some sort. But attributes are make these values the same for single resource type. |
I'm not clear on what issue you're having. Can you start over and elaborate on what the fundamental issue is? I don't know what this PR is addressing. Thanks. |
I do not see anything in the specification's schema that suggests name/title are valid on a resource contents: The docs from which you're citing "5.2.2 Binary Content" appear incorrect. |
Okay. Given modelcontextprotocol/modelcontextprotocol#1621 I think that's misunderstanding of spec on my side. But one question still remain
|
I will close this PR, but should I open an issue for that question? |
If there's a discrepancy between the spec and what's achievable with the SDK, an Issue is fine. |
Motivation and Context
This is to improve compliance with https://modelcontextprotocol.io/specification/2025-06-18/server/resources#data-types
How Has This Been Tested?
dotnet test
locallyBreaking Changes
That's non breacking change
Types of changes
Checklist
Additional context