Support --force for overwriting existing secrets
#1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@prbot approve |
![modal-pr-review-automation[bot]](https://avatars.githubusercontent.com/in/335990?s=60&v=4){kind=small}
ekzhang
reviewed
Feb 13, 2024
| @@ -43,12 +43,13 @@ async def list(env: Optional[str] = ENV_OPTION, json: Optional[bool] = False): | |||
| display_table(column_names, rows, json, title=f"Secrets{env_part}") | |||
|
|
|||
|
|
|||
| @secret_cli.command("create", help="Create a new secret") | |||
| @secret_cli.command("create", help="Create a new secret. Use `--force` to overwrite any existing one.") | |||
There was a problem hiding this comment.
We can add this to the option doc
There was a problem hiding this comment.
I don't think boolean options support documentation – I wasn't able to get it working and at least one Github Isssue suggests this is a missing feature in typer. Could be wrong though.
There was a problem hiding this comment.
Hm this worked for me here: https://github.com/modal-labs/modal-client/blob/main/modal/cli/token.py#L18-L21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't implemented on the server yet, but will do that next