Repository navigation
Conversation
New OTP 29 release throws warnings on `catch ...` expressions so translate them to `try ... catch ...` that's the biggest change. Since we're adding support for a new release, let's clean up and make OTP 23 the minumum. This way we can get rid of all the defines and we still get 6 years worth of Erlang releases. Noticed the ELP plugin was flagging `error_logger` as deprecated, so replaced it with `logger` `?LOG_` macros. Those should automatically log the module and function names. Application startup can also be simplified nowadays with `ensure_all_started/1`, so we can call that and not have to start applications one-by-one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New OTP 29 release throws warnings on
catch ...expressions so translate them totry ... catch ...that's the biggest change.Since we're adding support for a new release, let's clean up and make OTP 23 the minumum. This way we can get rid of all the defines and we still get 6 years worth of Erlang releases.
Noticed the ELP plugin was flagging
error_loggeras deprecated, so replaced it withlogger?LOG_macros. Those should automatically log the module and function names.Application startup can also be simplified nowadays with
ensure_all_started/1, so we can call that and not have to start applications one-by-one.