Skip to content

Add OTP 28 to CI and fix crypto:start() deprecation warning - #264

Merged
etrepum merged 3 commits into
mainfrom
add-otp-28-to-ci
Sep 17, 2025
Merged

etrepum merged 3 commits into
mainfrom
add-otp-28-to-ci

Conversation

@nickva

@nickva nickva commented Sep 17, 2025 •

Copy link
Copy Markdown
Collaborator

As separate commits:

  • Use OTP 28 in CI
  • Drop support for 18 and 19 as they started to fail in CI
  • Fix crypto:start() deprecation warning (should work as far back as OTP 18)

It's equivalent to `application:start(crypto)`

Documented to work as such since 18.0 at least:
 https://www.erlang.org/docs/18/man/crypto#start-0
iilyak-ibm
iilyak-ibm approved these changes Sep 17, 2025 •
@nickva

nickva commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator Author

Hmm 18 and 19 are failing:

Run actions/checkout@v3
  with:
    repository: mochi/mochiweb
    token: ***
    ssh-strict: true
    persist-credentials: true
    clean: true
    sparse-checkout-cone-mode: true
    fetch-depth: 1
    fetch-tags: false
    lfs: false
    submodules: false
    set-safe-directory: true
/usr/bin/docker exec  5605ac0f6bb137c8481a58679f4cc6ed2634d51a11621e1042924cd00c812ed4 sh -c "cat /etc/*release | grep ^ID"
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libm.so.6: version `GLIBC_2.27' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /__e/node20/bin/node)
/__e/node20/bin/node: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.25' not found (required by /__e/node20/bin/node)

What do you think, @etrepum, should we drop 18 and 19?

@etrepum

etrepum commented Sep 17, 2025

Copy link
Copy Markdown
Member

Dropping <20 sounds fine to me, that still supports back to mid-2017!

@iilyak-ibm

Copy link
Copy Markdown

+1

I am not suppose to approve on this repository. My mistake.

They started to fail in CI. With 20 -> 28 we still get a nice coverage as far
back as 2017.
@nickva
nickva requested a review from etrepum September 17, 2025 18:33
@etrepum
etrepum merged commit 53a5729 into main Sep 17, 2025
9 checks passed
@nickva
nickva deleted the add-otp-28-to-ci branch September 17, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants