Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove restrictions on null ipam driver #2078

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

clinta
Copy link
Contributor

@clinta clinta commented Feb 14, 2018

This PR removes the restrictions on the null driver, providing a workaround for the issue discussed in moby/moby#20547.

We would like to be able to have a custom network driver assign a specific IP to containers using the --ip parameter, but this cannot be done on a network created without --subnet. But we cannot create a network using the null driver with a specific subnet.

With this change we can create networks using our own network driver, and the null ipam driver, with specific subnets configured allowing containers to be configured with specif IP addresses.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "null-allow-subnet" [email protected]:clinta/libnetwork.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

Signed-off-by: Clint Armstrong <[email protected]>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@1ba8194). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2078   +/-   ##
=========================================
  Coverage          ?   40.56%           
=========================================
  Files             ?      138           
  Lines             ?    22175           
  Branches          ?        0           
=========================================
  Hits              ?     8995           
  Misses            ?    11857           
  Partials          ?     1323
Impacted Files Coverage Δ
ipams/null/null.go 39.39% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba8194...a1658b6. Read the comment docs.

@corhere corhere changed the title remove restrictions on null driver remove restrictions on null ipam driver Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants