Fix spatial shift in polygon-to-mask conversion#9
Open
skaliy wants to merge 1 commit intommiv-center:mainfrom
Open
Fix spatial shift in polygon-to-mask conversion#9skaliy wants to merge 1 commit intommiv-center:mainfrom
skaliy wants to merge 1 commit intommiv-center:mainfrom
Conversation
| int y = static_cast<int>(std::round(storage[storageIdx].coords[j + 1])); | ||
| // limit the coordinates in pixel to the bounding box | ||
| if (x < 0) | ||
| x = 0; |
Member
There was a problem hiding this comment.
It is unclear how this will change the apparent issue of moved masks. The change in pr2mask.cxx should have no effect as storage coordinates returned from PACS are already in integers. They are converted to bounding box coordinates in line 1047. Shouldn't there be a change afterwards if its to fix the issue?
The change in the scanline conversion should introduce an issue at the endpoints of polygons. This could have an effect. Has this been tested?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.