ci: add GitHub Actions CI workflow#25
Open
jackhamer09-ai wants to merge 1 commit intomm-zk-codex:mainfrom
Open
ci: add GitHub Actions CI workflow#25jackhamer09-ai wants to merge 1 commit intomm-zk-codex:mainfrom
jackhamer09-ai wants to merge 1 commit intomm-zk-codex:mainfrom
Conversation
Adds .github/workflows/ci.yml that runs on every PR and push to main:
- cargo fmt --check (enforces consistent formatting)
- cargo clippy -- -D warnings (denies all warnings)
- cargo build
- cargo test
Also fixes all pre-existing clippy warnings to make the baseline clean:
- Box large enum variant (TokenSubcommand::Send)
- Replace redundant closures with function pointers (Address::from_str)
- Replace .clone() on Copy types (FixedBytes<32>, tx hash) with deref
- Remove .to_string() in format! args
- Fix print_literal in format strings (chains, contracts)
- Replace .get(0) with .first()
- Replace print!("...\n") with println!
- Remove needless borrows in tx_show
- Add #[allow(clippy::too_many_arguments)] to async relay functions
- Fix field_reassign_with_default in Config::load
- Remove useless u64 identity conversion in chains
- Fix &PathBuf → &Path in contracts::build_row
- Fix if_same_then_else in doctor
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlthat runs on every PR and push tomainWhat the CI checks
cargo fmt --checkcargo clippy -- -D warningscargo buildcargo testResults are cached by
Cargo.lockhash so repeated runs are fast.Clippy fixes included
To make
cargo clippy -- -D warningspass cleanly onmain, the following pre-existing warnings were fixed:TokenSubcommand::Send)Address::from_str).clone()onCopytypes (FixedBytes<32>, tx hashes) with deref.to_string()informat!argsprint_literalinprintln!format strings.get(0)with.first()print!("...\n")withprintln!#[allow(clippy::too_many_arguments)]on async relay functionsfield_reassign_with_defaultinConfig::loadu64identity conversion&PathBuf→&Pathparameter typeif_same_then_elsein doctor commandTest plan
🤖 Generated with Claude Code