Remove mxalign testing functionality#15
Open
leifdenby wants to merge 1 commit into
Open
Conversation
Removing test functionality that validated loaded datasets with mxalign v0.1.0 and was used during development of first release of mlwp-data-loaders, to ensure identical behaviour of the refactored codebase (where functionality previously only in mxalign is now split in mlwp-data-specs, mlwp-data-loaders and mxalign itself).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing test functionality that validated loaded datasets with mxalign v0.1.0 and was used during development of first release of mlwp-data-loaders, to ensure identical behaviour of the refactored codebase (where functionality previously only in mxalign is now split in mlwp-data-specs, mlwp-data-loaders and mxalign itself).
The reason for removing this is that going forward
mxalignitself should depend onmlwp-data-specsandmlwp-data-loadersas the loading and trait validation is no longer done inmxalign(this work is being done in mlwp-tools/mxalign#30)