add ifs-forecast loader#12
Open
mpvginde wants to merge 16 commits into
Open
Conversation
mpvginde
commented
May 13, 2026
Contributor
Author
|
Thanks @leifdenby! Linting is fixed and test have passed. I think we can merge this. |
leifdenby
requested changes
Jun 23, 2026
leifdenby
left a comment
leifdenby
left a comment
Member
There was a problem hiding this comment.
Looking good :) A few suggestions for changes
leifdenby
reviewed
Jul 8, 2026
leifdenby
left a comment
leifdenby
left a comment
Member
There was a problem hiding this comment.
Only one small suggestion, looking great!
| try: | ||
| import cfgrib # noqa: F401 | ||
| except ImportError as e: | ||
| raise ImportError("Please install the cfgrib package to load IFS-Forecasts") from e |
Member
There was a problem hiding this comment.
should we maybe say:
This can be done by installing the
ifsoptional extra dependencies ofmlwp-data-loaderswith e.g.pip install mlwp-data-loaders[ifs]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds