Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caltech #125

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Prateek0xeo
Copy link

@Prateek0xeo Prateek0xeo commented Feb 17, 2025

#104
@cregouby
I have referred the pytorch vision library for this dataloader it is using google drive to load the data
My PR has not passed any test yet. I'll perfect the PR in the coming weeks and try to make the dataloader work
ISSUE
Another issue that i am coming up with is the get_image_size.magick-image Util that is not working in my dataloader
which i am trying to use for converting the images to RGB
Q.
also should I make the PR on top of the commits i did on the Eurosat or the main repo of torchvision(I'll delete this PR and make a new one)

@Prateek0xeo Prateek0xeo changed the title Add caltech dataloader Caltech Feb 17, 2025
@cregouby
Copy link
Contributor

cregouby commented Feb 17, 2025

Hello @Prateek0xeo

This P.R. cannot include the code change of the P.R. #122 ! They must be independant !

The branch you create for a new feature must be created from main, and not from your last branch.

To fix that, I would close that P.R. and before deleting your branch Prateek0xeo:add-caltech101-dataloader, recreate a brand new feature branch from main and import the files dedicated to caltech in it (via git checkout add-caltech101-dataloader -- dataset-caltech.R )

Then for the code in the file itself, please review #124 and apply it in here !

@Prateek0xeo Prateek0xeo force-pushed the add-caltech101-dataloader branch from ff616da to 9975346 Compare February 19, 2025 09:11
@Prateek0xeo
Copy link
Author

@cregouby
Instead of deleting i have force pushed my commits on the branch and deleted the commits from the Eurosat dataloader Is it fine?

@cregouby
Copy link
Contributor

cregouby commented Feb 20, 2025

Hello @Prateek0xeo
The scope of 5 files modified is OK, but the content is not fine at all. Please have a look at R/dataset-caltech.R.

@Prateek0xeo
Copy link
Author

@cregouby I tried using the google drive to load the dataset but was running into problems as I couldn't scrap the confirmation token from the website so i am trying hugging face now. there is still some problem with the code. I'll see if i can fix that.

@Prateek0xeo
Copy link
Author

ok so this new commit downloads the parquet file completely but still there are errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants