Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to improve the active-to-passive test translation:
The test runner now produces a full log of all RPCs. This is pretty chatty, since a lot of messages are reproduced as outputs and then input.s But it's very easy to parse.
The active-to-passive conversion script now uses the RPC log to build the passive tests.
The new
active_to_passive.sh
shell script runs all the configs and generates passive tests from them. It currently does not run ondeep_random.json
because the output is too large (Node saysError: Cannot create a string longer than 0x1fffffe8 characters
).The passive client tests resulting from this process with MLSpp are checked in under
interop/passive
.I have verified that the overall system holds together with MLSpp:
Note that there are some tests that do not result in any passive client tests right now, for example, the application data protection tests. This is largely because we are creating groups with
external_join
, and will get better once #144 is fixed