Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve active-to-passive #160

Merged
merged 3 commits into from
Mar 31, 2023
Merged

Improve active-to-passive #160

merged 3 commits into from
Mar 31, 2023

Conversation

bifurcation
Copy link
Collaborator

This PR makes a few changes to improve the active-to-passive test translation:

  • The test runner now produces a full log of all RPCs. This is pretty chatty, since a lot of messages are reproduced as outputs and then input.s But it's very easy to parse.

  • The active-to-passive conversion script now uses the RPC log to build the passive tests.

  • The new active_to_passive.sh shell script runs all the configs and generates passive tests from them. It currently does not run on deep_random.json because the output is too large (Node says Error: Cannot create a string longer than 0x1fffffe8 characters).

  • The passive client tests resulting from this process with MLSpp are checked in under interop/passive.

I have verified that the overall system holds together with MLSpp:

# Run the MLSpp interop harness
mlspp_client -live 50001

# Generate the passive tests
./active_to_passive.sh

# Verify the passive tests in MLSpp
for name in `ls passive`
do
  # 13 == passive client test vector
  mlspp_client -ver 13 <$name
done

Note that there are some tests that do not result in any passive client tests right now, for example, the application data protection tests. This is largely because we are creating groups with external_join, and will get better once #144 is fixed

@bifurcation bifurcation marked this pull request as ready for review March 30, 2023 21:07
Copy link
Collaborator

@mulmarta mulmarta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified the same sequence with Wickr.

@bifurcation bifurcation merged commit 24da1e5 into main Mar 31, 2023
@bifurcation bifurcation deleted the rpc-transcript branch March 31, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants