fix: Add drop_levels = FALSE to call of mlr3::convert_task() in PipeOpTargetMutate and PipeOpTargetTrafoScaleRange
#876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
advieser
changed the title
PipeOpTargetMutate does no longer drop missing factor levelsdrop_levels = FALSE to call of mlr3::convert_task() in PipeOpTargetMutate and PipeOpTargetTrafoScaleRange
|
We might instead want to add |
|
Also, I don't know whether we want to add the bikesharing example to mlr3website, now that it should work again? It was removed from mlr3gallery in 2021 because of this issue (see here). |
…lr3pipelines into fix/targettrafo_levels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PipeOpTargetMutateandPipeOpTargetTrafoScaleRange.trafohyperparameter ofPipeOpTargetMutatereturns a df/dt/matrix.closes #631