Fix to_pyg graph attribute mutation#143
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes weather_model_graphs.save.to_pyg() mutating the caller’s NetworkX graph by pruning node attributes on a copied graph prior to PyTorch Geometric conversion, and adds a regression test to prevent reintroduction.
Changes:
- Copy the input graph inside
to_pyg()and prune node attributes on the copy (not the caller-owned graph). - Ensure downstream conversion/splitting logic uses the copied/pruned graph consistently.
- Add a regression test that asserts the input graph’s node attributes remain unchanged while the exported/converted graph excludes unrequested attributes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/weather_model_graphs/save.py |
Avoids mutating the input graph by copying before pruning node attributes and exporting. |
tests/test_save.py |
Adds a regression test verifying to_pyg() does not delete node attributes on the caller graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #139.
Validation