Skip to content

flexible backend support by adding an abstraction layer (part of #128)#133

Open
Srishti-1806 wants to merge 1 commit into
mllam:mainfrom
Srishti-1806:feature/kdtree
Open

flexible backend support by adding an abstraction layer (part of #128)#133
Srishti-1806 wants to merge 1 commit into
mllam:mainfrom
Srishti-1806:feature/kdtree

Conversation

@Srishti-1806

@Srishti-1806 Srishti-1806 commented Apr 4, 2026

Copy link
Copy Markdown

Describe your changes

(#128 contains the full proposed pipeline from the GSoC proposal. This PR is part of breaking that contribution into smaller, focused PRs for better readability and review.)

This PR addresses a bug in KD-Tree based node mapping when connecting nodes across graphs.


Issue

Incorrect node mappings were observed during KD-Tree neighbor queries in cross-graph connections.
This led to inconsistent or incorrect graph connectivity.


Fix

  • Corrected index handling during KD-Tree neighbor queries
  • Ensured proper mapping between source and target graph nodes
  • Validated consistency of cross-graph connections

Result


Issue Link

Part of #128


Type of change

  • 🐛 Bug fix
  • ✨ New feature
  • 💥 Breaking change
  • 📖 Documentation

Testing

  • ✅ Verified correct node mapping across graphs
  • ✅ No incorrect neighbor assignments observed
  • ✅ Existing tests pass

Checklist before requesting a review

  • My branch is up-to-date with the target branch
  • Performed self-review
  • Added necessary comments for clarity
  • Ensured compatibility with existing code

Additional Notes for Reviewers

This PR is part of a larger effort (#128) to modularize the following proposed features:

  1. Backend Abstraction Layer ✅ (PR 1 - Done)
  2. Spatial Indexing Optimization (KD-Tree / Ball Tree)
  3. Temporal Graph Support
  4. Configuration-Driven Graph Pipeline
  5. Feature Engineering Layer
  6. ML Pipeline Integration
  7. Prebuilt Graph Architectures
  8. Dependency & Packaging Enhancements

The original PR (#128) is kept open as a reference for the complete integrated pipeline.

@Srishti-1806

Copy link
Copy Markdown
Author
image image image

##Screenshots proving successful implementation.

@Srishti-1806 Srishti-1806 changed the title Add KD-Tree based spatial indexing (1/8 feature of #128 PR) Add KD-Tree based spatial indexing for efficient neighbor search (1/8 of #128) Apr 4, 2026
@Srishti-1806 Srishti-1806 changed the title Add KD-Tree based spatial indexing for efficient neighbor search (1/8 of #128) [Bug Fix] KD-Tree node mapping bug in cross-graph connections and improve neighbor search (#82, part of #128) Apr 5, 2026
@Srishti-1806 Srishti-1806 changed the title [Bug Fix] KD-Tree node mapping bug in cross-graph connections and improve neighbor search (#82, part of #128) [Bug Fix] KD-Tree node mapping bug in cross-graph connections and nearest_neighbours crash (#82 and #83, part of #128) Apr 5, 2026
@Srishti-1806 Srishti-1806 changed the title [Bug Fix] KD-Tree node mapping bug in cross-graph connections and nearest_neighbours crash (#82 and #83, part of #128) flexible backend support by adding an abstraction layer (part of #128) Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant