Fix IndexError when visualizung subgraphs with zerod edges or nodes#131
Open
sudhansu-24 wants to merge 2 commits into
Open
Fix IndexError when visualizung subgraphs with zerod edges or nodes#131sudhansu-24 wants to merge 2 commits into
sudhansu-24 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
guards
wmg.visualise.plot_2dfrom crashing withIndexErrorwhen attempting to apply attribute coloring to empty graph components (zero edges or zero nodes).when splitting graphs via
filter_graphorsplit_graph_by_edge_attribute, users often process a dictionary of subgraphs. If a subgraph contains nodes but no edges (or is completely empty), plotting it with anedge_color_attrused to crash inside_get_graph_attr_valuesbecause it indexed[0]on an empty listThis PR fixes it by:
nx_draw_with_pos_and_attrto gracefully skip coloring whennumber_of_edges() == 0ornumber_of_nodes() == 0.ValueErrorinside_get_graph_attr_valuesfor when it is called directly on empty graph components.test_graph_plots.pycovering these edge cases.Issue Link
solves #130
Type of change
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee