Skip to content

Fix IndexError when visualizung subgraphs with zerod edges or nodes#131

Open
sudhansu-24 wants to merge 2 commits into
mllam:mainfrom
sudhansu-24:fix/visualise-empty-subgraph-bug
Open

Fix IndexError when visualizung subgraphs with zerod edges or nodes#131
sudhansu-24 wants to merge 2 commits into
mllam:mainfrom
sudhansu-24:fix/visualise-empty-subgraph-bug

Conversation

@sudhansu-24

@sudhansu-24 sudhansu-24 commented Apr 3, 2026

Copy link
Copy Markdown

Describe your changes

guards wmg.visualise.plot_2d from crashing with IndexError when attempting to apply attribute coloring to empty graph components (zero edges or zero nodes).

when splitting graphs via filter_graph or split_graph_by_edge_attribute, users often process a dictionary of subgraphs. If a subgraph contains nodes but no edges (or is completely empty), plotting it with an edge_color_attr used to crash inside _get_graph_attr_values because it indexed [0] on an empty list

This PR fixes it by:

  1. Adding early-exit guards in nx_draw_with_pos_and_attr to gracefully skip coloring when number_of_edges() == 0 or number_of_nodes() == 0.
  2. Adding a descriptive ValueError inside _get_graph_attr_values for when it is called directly on empty graph components.
  3. Adding 4 regression tests to test_graph_plots.py covering these edge cases.

Issue Link

solves #130

Type of change

  • 🐛 Bug fix (non-breaking change that fixes an issue)
  • ✨ New feature (non-breaking change that adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📖 Documentation (Addition or improvements to documentation)

Checklist before requesting a review

  • My branch is up-to-date with the target branch - if not update your fork with the changes from the target branch (use pull with --rebase option if possible).
  • I have performed a self-review of my code
  • For any new/modified functions/classes I have added docstrings that clearly describe its purpose, expected inputs and returned values
  • I have placed in-line comments to clarify the intent of any hard-to-understand passages of my code
  • [] I have updated the documentation to cover introduced code changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have given the PR a name that clearly describes the change, written in imperative form (context).
  • I have requested a reviewer and an assignee (assignee is responsible for merging)

Checklist for reviewers

Each PR comes with its own improvements and flaws. The reviewer should check the following:

  • the code is readable
  • the code is well tested
  • the code is documented (including return types and parameters)
  • the code is easy to maintain

Author checklist after completed review

  • I have added a line to the CHANGELOG describing this change, in a section
    reflecting type of change (add section where missing):
    • added: when you have added new functionality
    • changed: when default behaviour of the code has been changed
    • fixes: when your contribution fixes a bug

Checklist for assignee

  • PR is up to date with the base branch
  • the tests pass
  • author has added an entry to the changelog (and designated the change as added, changed or fixed)
  • Once the PR is ready to be merged, squash commits and merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant