refactor: rename d_mesh_static dimension to num_mesh_static_vars#695
refactor: rename d_mesh_static dimension to num_mesh_static_vars#695uttam12331 wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Thanks @uttam12331, the rename is clean and complete: d_mesh_static is gone everywhere and num_mesh_static_vars matches the num_* family we agreed in the #635 review. Good call leaving the README and the N_mesh cleanup out of scope too, the README list arrives with #635 (still open) and keeping this to one concern is right.
One change needed before merge: please add a CHANGELOG entry. It is mandatory for every PR), and a doc/comment rename fits the ### Maintenance section:
- Rename the `d_mesh_static` mesh-node static-feature dimension to `num_mesh_static_vars` in comments and docstrings, matching the canonical `num_*` naming. [\#695](https://github.com/mllam/neural-lam/pull/695) @uttam12331Two notes on our contributing flow for next time, not specific to the code here:
- Please comment on the issue and get it assigned before opening a PR, so we avoid duplicate effort. #687 already had another interested contributor, and commenting first keeps it clear who is on it.
- Please fill in the PR template in full (
.github/pull_request_template.md) rather than a free-form description. The content you wrote is good, it just needs to live in the template sections.
Let me know once the CHANGELOG is in and I will re-review.
|
Thanks for the review @sadamov! Added the CHANGELOG entry under |
|
Please fix the PR template. |
|
Thanks @joeloskarsson — updated the PR description to follow the template (filled in the change summary, linked |
|
@uttam12331 the PR-template is still cut off. Please be especially careful when using agents, as these tend to mess with the template. |
|
Thanks for the patience @sadamov — the template was cut off (missing the Checklist for reviewers and Checklist for assignee sections). Both are now included in full. Ready for re-review. |
Describe your changes
Rename the mesh-node static-feature dimension
d_mesh_statictonum_mesh_static_varsin comments and docstrings, so the name matches thecanonical
num_*naming used across the codebase (as agreed in the #635review). This is a naming/documentation change only — no runtime behaviour is
altered.
The README dimension list and the broader
N_meshcleanup are intentionallyleft out of scope: the README list arrives with #635 (still open), and keeping
this PR to a single concern was requested in review.
No new dependencies.
Issue Link
closes #687
Type of change
Checklist before requesting a review
Checklist for reviewers
Author checklist after completed review
Checklist for assignee