feat: add --num_sanity_val_steps CLI argument to train_model#694
Open
Kirwa-web wants to merge 2 commits into
Open
feat: add --num_sanity_val_steps CLI argument to train_model#694Kirwa-web wants to merge 2 commits into
Kirwa-web wants to merge 2 commits into
Conversation
Author
|
@joeloskarsson would appreciate a review when you get a chance. This adds the --num_sanity_val_steps argument referenced in #138. |
joeloskarsson
approved these changes
Jul 3, 2026
joeloskarsson
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the addition, this looks good to me!
I don't see a reasonable way to add a test for this, as that would pretty much mean testing pure pytorch lightning functionality. We are here just exposing an argument of the pl.Trainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a
--num_sanity_val_stepsargument to control the number of sanity validation steps run before training, as referenced in #138.--num_sanity_val_stepsto the Training Options argument group (default: 2, matching PyTorch Lightning's default)pl.Trainervianum_sanity_val_steps=args.num_sanity_val_stepsThis is useful for debugging training runs without waiting through full sanity validation steps.
Checklist before requesting a review
pullwith--rebaseoption if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee