-
Notifications
You must be signed in to change notification settings - Fork 276
feat: add optional boundary datastore support #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sadamov
wants to merge
43
commits into
mllam:main
Choose a base branch
from
sadamov:feat/boundary-datastore
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
dee15d1
feat: add optional boundary datastore support in WeatherDataset
sadamov 3dc0045
Update CHANGELOG PR link to #635
sadamov e945a4d
feat: add ERA5 boundary datastore test configs and conftest fixture
sadamov 10e1877
fix: handle boundary-only MDP datastores without state variables
sadamov affb441
docs: mention MDP boundary-only datastore support in CHANGELOG
sadamov c3af69e
fix: handle boundary-only NpyFilesDatastoreMEPS without state variables
sadamov e5d8061
fix: MDP get_vars_names/get_vars_long_names for any missing category
sadamov 8d8bb77
fix: add num_grid_points override to MDPDatastore
sadamov 2b12e76
Merge branch 'main' into feat/boundary-datastore
sadamov b3e4ef6
Merge remote-tracking branch 'sadamov/feat/boundary-datastore' into f…
sadamov 4c94adc
test: tighten ERA5 boundary test fixture and skip slow by default
sadamov 3e6e246
test: enforce stateless boundary datastore in BoundaryDummyDatastore
sadamov a839263
Merge branch 'main' into feat/boundary-datastore
sadamov 39534a1
Merge origin/main into feat/boundary-datastore
sadamov 41ee6f6
Merge branch 'main' of https://github.com/mllam/neural-lam into feat/…
sadamov cf323a8
fix(mdp): require state or forcing in datastore and simplify grid_sha…
sadamov 0ec56f5
docs(models): mark boundary_features as not yet used in common_step
sadamov 140caf5
feat(dataset): align boundary forcing to interior times across analys…
sadamov cbc1c14
test(time-slicing): cover boundary windowing and mixed forecast modes
sadamov 9a9af31
feat(models): standardize boundary forcing on-device in ForecasterModule
sadamov a543ce9
fix(dataset): anchor forecast boundary on model init time
sadamov efe542d
Merge main into feat/boundary-datastore
sadamov 685e257
ci: pass --run-slow to pytest so slow tests run in CI
sadamov 78a4d52
test/ci: drop --run-slow plumbing in favour of pytest -m
sadamov 6e0a2c6
refactor(config): use named datastores mapping with role implied by c…
sadamov df736ec
Merge remote-tracking branch 'origin/main' into feat/boundary-datastore
sadamov f8d43ff
docs(pytest): correct slow-marker description to run-by-default
sadamov 720530f
feat(config): raise migration error for legacy datastore key
sadamov 22310b6
linting formatting and detailed review
sadamov 34ee3df
docs: document state/forcing/static category meaning
sadamov 1a4ff17
Merge branch 'main' into feat/boundary-datastore
sadamov 059033d
Drop unimplemented diagnostic category note from README
sadamov 8b08abd
Document single-boundary-datastore constraint in README
sadamov 682f792
Update neural_lam/train_model.py
sadamov dc0585d
Rename da1/da2 to da_requested/da_available in time helpers
sadamov ec71402
Crop forecast interior along analysis_time to boundary coverage
sadamov dccb7a6
Make time-overlap helper messages domain-agnostic
sadamov ddf882c
Use forecast max lead time in boundary coverage bound
sadamov 441ce61
Use binary search for the crop cut points
sadamov a75a1ad
Remove dead time-step attributes from WeatherDataset
sadamov 8a2dc12
Make crop_time_if_needed the single coverage source of truth
sadamov 812d25a
Raise ValueError instead of assert in boundary windowing
sadamov c096dc4
added helper for empty dataarrays
sadamov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.