Fix geocoding fallback when AMap key is missing#21
Open
mlintangmz2765 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
amap_web_keyis not configured and keep the Google fallback behavior safe.Description
GeocodingService::getCoordinatesChina()to immediately return['lat' => 0.0, 'lng' => 0.0]when theamap_web_keyconfig is empty, avoiding calls to AMap endpoints.Testing
php -l app/Services/GeocodingService.phpwhich passed; runningcomposer testis currently blocked becausevendor/autoload.phpis missing in this environment.Codex Task