Fix custom error pages extending wrong Blade view namespace#18
Open
mlintangmz2765 wants to merge 1 commit into
Open
Fix custom error pages extending wrong Blade view namespace#18mlintangmz2765 wants to merge 1 commit into
mlintangmz2765 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
resources/views/errors/*attempted to extend a namespaced view (errors::layout) which can fail if the namespace is not registered, causing error pages to throw a secondary view-resolution exception.Description
@extends('errors::layout')with@extends('errors.layout')across the seven custom error templates (401,403,404,419,429,500,503) so Laravel resolves the localresources/views/errors/layout.blade.phpcorrectly.Testing
php -lon PHP files (no syntax errors) and searched for remainingerrors::layoutusages (none found);composer testfailed due to missingvendor/autoload.phpandcomposer installcould not complete because of network/proxy errors when fetching packages.Codex Task