MLDB-1735 make ln/log behave like postgresql's #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
simlmx
commented
Aug 18, 2016
simlmx
commented
- add support for log(x) and log(b,x) that match postgresql's functions
- make log/ln and sqrt not fail on 0/negative values and return nan/-inf instead
- fix a few typos in the doc
- simplify the numeric-functions test file
added 3 commits
August 18, 2016 12:05
…r when wrong number of arguments
| @@ -778,17 +778,64 @@ registerMod(mod, std::make_shared<IntegerValueInfo>(), "mod"); | |||
| double ln(double v) | |||
| { | |||
| if (v <= 0) | |||
| throw HttpReturnException(400, "the argument of the ln function must" | |||
| " be strictly positive"); | |||
| cerr << "negative value encountered in ln" << endl; | |||
There was a problem hiding this comment.
Please remove the cerr, this could happen on every row and kill performance in a very nasty way.
|
+1 after removing the cerr's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.