Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch PAT with KSM in sync.yml #332

Merged
merged 6 commits into from
Feb 20, 2025
Merged

Fetch PAT with KSM in sync.yml #332

merged 6 commits into from
Feb 20, 2025

Conversation

nathanw-mlc
Copy link
Member

@nathanw-mlc nathanw-mlc commented Jan 10, 2025

This PR implements KSM to fetch the ACCESS_TOKEN and INFERENCE_ACCESS_TOKEN from Keeper rather than the GitHub repository secrets. We are implementing KSM across our infrastructure to centralize key management and streamline key rolling. The current keys in the repo expire on Jan 12th, so we are taking this expiration as an opportunity to switch to KSM.

Copy link

github-actions bot commented Jan 10, 2025

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@nathanw-mlc nathanw-mlc marked this pull request as ready for review January 10, 2025 03:25
@nathanw-mlc nathanw-mlc requested a review from a team as a code owner January 10, 2025 03:25
Copy link
Contributor

@araghun araghun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per Arjun.. This PR from Nathan is required to sync the power checker to the inference repository. Has been verified by Arjun.

@araghun araghun merged commit b96489f into master Feb 20, 2025
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 20, 2025
@nathanw-mlc nathanw-mlc deleted the implement-ksm branch February 24, 2025 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants