Potential fix for code scanning alert no. 12: Incomplete URL substring sanitization #172
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/mlcommons/mlcflow/security/code-scanning/12
The right way to fix this is to properly parse the
repo
variable as a URL, then check whether the hostname is exactly "github.com" or possibly in an allowlist of trusted hostnames (such as "github.com", optionally supporting subdomains if that is a use case).urllib.parse.urlparse
to parserepo
if it's a URL..hostname
property for equality with"github.com"
. (Not a substring or endswith check.)self.github_url_to_user_repo_format
if the parsed hostname is trusted.elif "github.com" in repo:
with a proper parse and check.https://evil.com/github.com/foo
do not pass.The code to import is
from urllib.parse import urlparse
. Insert this import if not present.All changes are confined to function(s) within
mlc/repo_action.py
as shown.Suggested fixes powered by Copilot Autofix. Review carefully before merging.