Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated test_mlc_access.py and added logging and assert statement #123

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Updated test_mlc_access.py and added logging and assert statement #123

wants to merge 8 commits into from

Conversation

sahilavaran
Copy link
Contributor

No description provided.

@sahilavaran sahilavaran requested a review from a team as a code owner March 1, 2025 18:29
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025 •
edited
Loading

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@sahilavaran sahilavaran changed the title Updated test_mlc_access.py and added logging and pytest Updated test_mlc_access.py and added logging and assert statement Mar 6, 2025
anandhu-eng
anandhu-eng reviewed Mar 6, 2025
View reviewed changes
anandhu-eng
anandhu-eng reviewed Mar 6, 2025
View reviewed changes
.github/scripts/test_mlc_access.py Outdated
import mlc

# Configure logging
logging.basicConfig(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could reuse the logger from mlc right?

@anandhu-eng
Copy link
Contributor

anandhu-eng commented Mar 7, 2025 •
edited
Loading

Hi @sahilavaran , the error in this test case arose because it tried to access the logger.py file.

>>> import mlc
>>> mlc.logger
<module 'mlc.logger' from '/home/anandhu/testing/mlcflow/mlc/logger.py'>

I think we could provide an endpoint for the users(could be found in this PR) to get the MLC logger.

@sahilavaran
Copy link
Contributor Author

@anandhu-eng added as per your PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anandhu-eng anandhu-eng anandhu-eng left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahilavaran @anandhu-eng