Repository navigation
patch the dataset sample progress bar - #516
Merged
Merged
Conversation
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
=======================================
Coverage ? 80.92%
=======================================
Files ? 154
Lines ? 21247
Branches ? 0
=======================================
Hits ? 17194
Misses ? 4053
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
nvzhihanj
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
this PR fixes the progress bar display bug when issued trajectory is over the agentic performance dataset total trajectory count.
Without the fix, after 20403 turns, the display will output malformed line.
However, this fix is not a long term elegant fix because the existing flag
num_trajectories_to_issue: 613should logically belong toinstead of under
In order to not break everyone's client.yaml during loading, I decided to implement this temp patch to make the API not changing. however, after this round of submission. This needs a broder refactor.
Filed an issue to track later
#517
Type of change
Related issues
Testing
Checklist